Skip to content

[web] Fix handlers not sending events #3911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
m-bert merged 2 commits into from
Jan 9, 2026
Merged

[web] Fix handlers not sending events #3911

m-bert merged 2 commits into from
Jan 9, 2026
+1 −1

Conversation

@m-bert
Copy link
Contributor

@m-bert m-bert commented Jan 9, 2026

Description

#3877 accidentally broke handlers - they stopped sending events, as in this line I was comparing this._enabled to undefined, while it was in fact null.

We we could also change this and use undefined instead of null, let me know.

Test plan

Tested on expo-example (mostly velocity and web styles reset examples).

@m-bert m-bert requested a review from akwasniewski January 9, 2026 12:24
akwasniewski
akwasniewski approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@akwasniewski akwasniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

@m-bert m-bert merged commit 6352af3 into next Jan 9, 2026
1 check passed
@m-bert m-bert deleted the @mbert/fix-web-handlers branch January 9, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akwasniewski akwasniewski akwasniewski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@m-bert @akwasniewski