ci: beta release-please versioning-strategy 및 버전 복원#118
Merged
Palbahngmiyine merged 1 commit intosolapi:betafrom Apr 8, 2026
Merged
ci: beta release-please versioning-strategy 및 버전 복원#118Palbahngmiyine merged 1 commit intosolapi:betafrom
Palbahngmiyine merged 1 commit intosolapi:betafrom
Conversation
- versioning-strategy: prerelease 추가 (6.0.0-beta.0 형식 생성) - package.json version을 5.5.4로 복원 (manifest와 일치, release-please가 bump) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request downgrades the package version to 5.5.4 and updates the release-please configuration to include a prerelease versioning strategy. A review comment correctly identifies that manually changing the version in package.json requires an update to the pnpm-lock.yaml file to ensure consistency and prevent CI failures.
| { | ||
| "name": "solapi", | ||
| "version": "6.0.0", | ||
| "version": "5.5.4", |
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
기능 변경사항
release-please-config-beta.json에versioning-strategy: "prerelease"를 추가했습니다.package.jsonversion을5.5.4로 복원했습니다. (manifest와 일치)프로젝트 내부 변경사항
release-please가 beta 브랜치에서 config를 읽기 때문에, master에만 반영된 설정이 적용되지 않았습니다.
근본 원인 (3가지):
versioning-strategy: "prerelease"미설정 →6.0.0으로 계산 (6.0.0-beta.0아님)package.json이 이미6.0.0→ release-please가 "updating from 6.0.0 to 6.0.0" (변경 없음)수정 후 예상 동작:
5.5.4+feat!커밋 →6.0.0-beta.0계산package.json5.5.4→6.0.0-beta.0으로 bumpTest plan
6.0.0-beta.0릴리스 PR 생성 확인🤖 Generated with Claude Code