ci: biome formatter에서 package.json 제외#126
Merged
Palbahngmiyine merged 1 commit intosolapi:betafrom Apr 8, 2026
Merged
Conversation
release-please가 package.json 업데이트 시 포맷을 변경하여 biome check(lint:ci)에서 포맷 에러가 발생한다. package.json은 release-please가 관리하므로 formatter 대상에서 제외. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Biome configuration to exclude package.json from the formatter. A review comment suggests using the ignore field instead of a negation pattern within the includes field to improve clarity and avoid potential conflicts with global inclusion settings.
| "formatter": { | ||
| "enabled": true, | ||
| "formatWithErrors": false, | ||
| "includes": ["**", "!package.json"], |
There was a problem hiding this comment.
특정 파일을 제외할 때는 includes 필드에서 부정 패턴(!)을 사용하는 것보다 ignore 필드를 사용하는 것이 더 명확하고 권장되는 방식입니다. includes에 **를 다시 선언하는 것은 전역 files.includes 설정과 중복될 수 있으며, ignore를 사용하면 전역 포함 로직을 건드리지 않고 특정 파일만 안전하게 제외할 수 있습니다.
Suggested change
| "includes": ["**", "!package.json"], | |
| "ignore": ["package.json"], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
기능 변경사항
package.json을 제외했습니다.프로젝트 내부 변경사항
release-please가
package.json을 업데이트할 때"files"배열을 multi-line으로 포맷합니다.biome는 single-line을 기대하므로
lint:ci(biome check)에서 포맷 에러가 발생합니다.release-please가 매 릴리스마다
package.json을 수정하므로, formatter 대상에서 제외하는 것이 올바른 해결책입니다.Test plan
🤖 Generated with Claude Code