WIP: feat: add migrating to v2 solid-start guide #1378
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
amirhhashemi
requested changes
Dec 18, 2025
Comment on lines
+65
to
+67
| ```bash | ||
| pnpm remove vinxi | ||
| ``` |
Collaborator
There was a problem hiding this comment.
Suggested change
| ```bash | |
| pnpm remove vinxi | |
| ``` | |
| ```package-remove | |
| vinxi | |
| ``` |
In order for this to work you also need to define the remove command in app.config.ts within the packageManagers object.
Comment on lines
+53
to
+54
| import { solidStart } from "@solidjs/start/config"; | ||
| export default defineConfig({ |
Collaborator
There was a problem hiding this comment.
Suggested change
| import { solidStart } from "@solidjs/start/config"; | |
| export default defineConfig({ | |
| import { solidStart } from "@solidjs/start/config"; | |
| export default defineConfig({ |
Comment on lines
+37
to
+38
| import { solidStart } from "@solidjs/start/config"; | ||
| export default defineConfig({ |
Collaborator
There was a problem hiding this comment.
Suggested change
| import { solidStart } from "@solidjs/start/config"; | |
| export default defineConfig({ | |
| import { solidStart } from "@solidjs/start/config"; | |
| export default defineConfig({ |
amirhhashemi
requested changes
Dec 18, 2025
Comment on lines
+86
to
+88
| **6. Replace all leftover vinxi imports** | ||
|
|
||
| - `useSession` now comes from `@solidjs/start/server` instead of `vinxi/http |
Collaborator
There was a problem hiding this comment.
Suggested change
| **6. Replace all leftover vinxi imports** | |
| - `useSession` now comes from `@solidjs/start/server` instead of `vinxi/http | |
| **6. Replace all imports from `vinxi/http` with `@solidjs/start/http`** |
It seems that nearly all exports from vinxi/http have been moved to @solidjs/start/http. A few functions are not, but I don't think they are relevant to users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description(required)
Related issues & labels