Skip to content

fix(signals): clear uninitialized optimistic async completion#2806

Open
brenelz wants to merge 1 commit into
solidjs:nextfrom
brenelz:fix/optimistic-first-refresh-pending
Open

fix(signals): clear uninitialized optimistic async completion#2806
brenelz wants to merge 1 commit into
solidjs:nextfrom
brenelz:fix/optimistic-first-refresh-pending

Conversation

@brenelz

@brenelz brenelz commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • clear STATUS_UNINITIALIZED after the first successful completion of a resting async createOptimistic source
  • add a regression test for the first refresh when isPending is the only consumer
  • add a patch changeset for @solidjs/signals

Testing

  • pnpm --filter @solidjs/signals test -- tests/createOptimistic.test.ts

@changeset-bot

changeset-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 362fc2f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@solidjs/signals Patch
test-integration Patch
solid-js Patch
babel-preset-solid Patch
@solidjs/web Patch
@solidjs/html Patch
@solidjs/h Patch
@solidjs/universal Patch
@solidjs/element Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codspeed-hq

codspeed-hq Bot commented Jun 30, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 116 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
omit 172.1 µs 215.9 µs -20.28%
merge 285.2 µs 222.1 µs +28.41%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing brenelz:fix/optimistic-first-refresh-pending (362fc2f) with next (9892af2)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant