Skip to content

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Feb 9, 2026

See: #650
Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="test/ci/pass_validate_fuse.sh">

<violation number="1" location="test/ci/pass_validate_fuse.sh:38">
P2: Capture both stdout and stderr for this verbose CLI test so unexpected output on either stream is asserted.

(Based on your team's feedback about capturing stdout and stderr using verbose tests.) [FEEDBACK_USED]</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.


bindfs "$TMP" "$FUSE_MOUNT"

"$1" validate --verbose "$FUSE_MOUNT/level1/level2/level3/schema.json" "$FUSE_MOUNT/instance.json" 2> "$TMP/output.txt"
Copy link

@cubic-dev-ai cubic-dev-ai bot Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Capture both stdout and stderr for this verbose CLI test so unexpected output on either stream is asserted.

(Based on your team's feedback about capturing stdout and stderr using verbose tests.)

View Feedback

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At test/ci/pass_validate_fuse.sh, line 38:

<comment>Capture both stdout and stderr for this verbose CLI test so unexpected output on either stream is asserted.

(Based on your team's feedback about capturing stdout and stderr using verbose tests.) </comment>

<file context>
@@ -0,0 +1,48 @@
+
+bindfs "$TMP" "$FUSE_MOUNT"
+
+"$1" validate --verbose "$FUSE_MOUNT/level1/level2/level3/schema.json" "$FUSE_MOUNT/instance.json" 2> "$TMP/output.txt"
+
+cat << EOF > "$TMP/expected.txt"
</file context>
Fix with Cubic

@augmentcode
Copy link

augmentcode bot commented Feb 9, 2026

🤖 Augment PR Summary

Summary: Adds a real FUSE-based CI test on Linux to validate path handling through a mounted filesystem.

Changes:

  • Installs bindfs in the Linux (native) GitHub Actions job
  • Registers a new Linux-only CTest entry pass_validate_fuse
  • Adds test/ci/pass_validate_fuse.sh which mounts a temp tree via FUSE and runs jsonschema validate --verbose

Technical Notes: The test asserts the CLI’s verbose output using paths under the FUSE mount to catch issues that don’t reproduce on a normal filesystem.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

- name: Install dependencies (Linux)
if: runner.os == 'linux' && matrix.platform.type == 'native'
run: sudo apt-get update --yes && sudo apt-get install --yes zsh
run: sudo apt-get update --yes && sudo apt-get install --yes zsh bindfs
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This installs bindfs only for the native Linux job, but pass_validate_fuse is enabled for any Linux build (including the Alpine container and WSL jobs), which may fail due to missing bindfs and/or unavailable FUSE support. Consider aligning the CI dependency install with where the test is actually enabled so the matrix doesn’t become red unexpectedly.

Severity: high

Other Locations
  • test/CMakeLists.txt:592
  • test/ci/pass_validate_fuse.sh:36

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

FUSE_MOUNT="$(mktemp -d)"
clean() {
fusermount -u "$FUSE_MOUNT" 2>/dev/null || true
rm -rf "$TMP" "$FUSE_MOUNT"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With set -o errexit, the cleanup rm -rf can fail if the mount wasn’t successfully unmounted (e.g., if fusermount isn’t available or the unmount fails), which can make the test flaky and can mask the original failure. Making the cleanup more failure-tolerant would help keep the reported failure signal accurate.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

See: #650
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant