fix: preserve selected parameterized tests - #159
Merged
mkolasinski-splunk merged 2 commits intoSep 16, 2026
Merged
mkolasinski-splunk merged 2 commits into
mkolasinski-splunk merged 2 commits into
Conversation
mkolasinski-splunk
requested review from
a team,
hsekowski-splunk and
okashaev-splunk
as code owners
September 6, 2026 00:05
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
mbruzda-splunk
approved these changes
Sep 16, 2026
mkolasinski-splunk
deleted the
codex/ADDON-89948-partial-param-deselection-v2.0.5
branch
September 16, 2026 13:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: ADDON-89948
PR Type
What kind of change does this PR introduce?
Summary
Changes
Backports the partial parameterized-test deselection fix onto the
v2.0.5line. The pytest hook now unregisters only the deselected parameter instance instead of unregistering every instance belonging to the same original test function.The regression scenario selects one parameter with
-m selectedand proves that only that parameter's fixture executes while the other parameter remains deselected.User experience
Before this change, marker selection of one case from a parameterized UCC functional test could remove the selected case's dependency metadata and fail fixture resolution. After this change, selected parameter instances retain their correct dependency graph.
Validation
6 passed17 passedRelease
This PR targets maintenance branch
2.0.x, created from tagv2.0.5. After merge, manually dispatch the CI workflow on2.0.x; semantic-release recognizes this maintenance branch and should publish patch release2.0.6.Checklist
If an item doesn't apply to your changes, leave it unchecked.
AI Tool Assistance Usage Statement