Skip to content

Group by actual template names instead of file name#3991

Open
henryy-splunk wants to merge 2 commits intodevelopfrom
update-template-script
Open

Group by actual template names instead of file name#3991
henryy-splunk wants to merge 2 commits intodevelopfrom
update-template-script

Conversation

@henryy-splunk
Copy link
Copy Markdown
Collaborator

@henryy-splunk henryy-splunk commented Apr 2, 2026

Details

Previously we are grouping the response templates by file name. This means that if the file name gets changed SelfReplicated_v1.json -> Self-Replicated_v2.json, it would be a new line in the manifest for response template.

The change here is to group them by the actual response template name, meaning if the response template file is
SelfReplicated_v1.json -> name: Self-Replicated, version: 1
Self-Replicated_v2.json -> name: Self-Replicated, version: 2
they would be grouped as the same.

Also add validation such that we have unique response_template name and version pairs.

Things to look out for:
The response template file names and links are url encoded.

Checklist

  • Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature
  • CI/CD jobs passed ✔️
  • Validated SPL logic.
  • Validated tags, description, and how to implement.
  • Verified references match analytic.
  • Confirm updates to lookups are handled properly.

Notes For Submitters and Reviewers

  • If you're submitting a PR from a fork, ensuring the box to allow updates from maintainers is checked will help speed up the process of getting it merged.
  • Checking the output of the build CI job when it fails will likely show an error about what is failing. You may have a very descriptive error of the specific field(s) in the specific file(s) that is causing an issue. In some cases, its also possible there is an issue with the YAML. Many of these can be caught with the pre-commit hooks if you set them up. These errors will be less descriptive as to what exactly is wrong, but will give you a column and row position in a specific file where the YAML processing breaks. If you're having trouble with this, feel free to add a comment to your PR tagging one of the maintainers and we'll be happy to help troubleshoot it.
  • Updates to existing lookup files can be tricky, because of how Splunk handles application updates and the differences between existing lookup files being updated vs new lookups. You can read more here but the short version is that any changes to lookup files need to bump the the date and version in the associated YAML file.

@nasbench nasbench added this to the v5.26.0 milestone Apr 2, 2026
Copy link
Copy Markdown
Collaborator

@kbouchardherjavecgroup kbouchardherjavecgroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you.

@henryy-splunk
Copy link
Copy Markdown
Collaborator Author

thank you.

Can I get your approval as well? Thanks!

Copy link
Copy Markdown
Collaborator

@kbouchardherjavecgroup kbouchardherjavecgroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@henryy-splunk
Copy link
Copy Markdown
Collaborator Author

Please merge in after #3990 gets merged. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants