Avoid expensive de-duplication in BootstrapPropertySource#getPropertyNames.#1631
Open
qnnn wants to merge 1 commit intospring-cloud:mainfrom
Open
Avoid expensive de-duplication in BootstrapPropertySource#getPropertyNames.#1631qnnn wants to merge 1 commit intospring-cloud:mainfrom
qnnn wants to merge 1 commit intospring-cloud:mainfrom
Conversation
qnnn
force-pushed
the
main
branch
2 times, most recently
from
c61a128 to
e90f0af
Compare
…Names. Signed-off-by: qnnn <qiunan@cmbchina.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have several existing applications that are still using Bootstrap for configuration refresh (version 3.1.x). Recently, I noticed that when there is a large amount of configuration, triggering a refresh can cause a significant CPU spike. I observed the same behavior in the newer version (2025.1.0) as well. The main overhead seems to come from ConfigurationProperties binding.
In addition, the cost of BootstrapPropertySource.getPropertyNames() is also quite noticeable. Since BootstrapPropertySource is essentially an enumerable wrapper, it does not seem necessary to perform de-duplication in getPropertyNames(). Therefore, this PR proposes changing the implementation to directly return the delegate’s getPropertyNames() result, in order to reduce some of the overhead.
Here is the minimal reproducible project along with its corresponding flame graph.
demo.zip(version 2025.1.0)
ps: The refresh is triggered via the refresh endpoint.
flamegraph.html