Skip to content

Return proxied Statement from ObservationStatement mutator calls#1652

Closed
BenEfrati wants to merge 1 commit into
spring-projects:mainfrom
BenEfrati:GH-1651
Closed

Return proxied Statement from ObservationStatement mutator calls#1652
BenEfrati wants to merge 1 commit into
spring-projects:mainfrom
BenEfrati:GH-1651

Conversation

@BenEfrati
Copy link
Copy Markdown
Contributor

@BenEfrati BenEfrati commented May 15, 2026 •
edited
Loading

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 15, 2026
@BenEfrati
spring-projectsGH-1651: Return proxied Statement for mutator calls
0425bce 
Add test to verify proxy preserves Observation

Signed-off-by: Ben Efrati <BenEfrati@users.noreply.github.com>
@mp911de mp911de linked an issue May 26, 2026 that may be closed by this pull request
ObservationRequestTracker remains open for observed Cassandra statements #1651
Closed
@mp911de mp911de added the type: bug A general bug label May 28, 2026
@mp911de mp911de self-assigned this May 28, 2026
@mp911de mp911de changed the title GH-1651: Return proxied Statement for mutator calls Return proxied Statement for ObservationStatement mutator calls May 28, 2026
@mp911de mp911de removed the status: waiting-for-triage An issue we've not yet triaged label May 28, 2026
@mp911de mp911de changed the title Return proxied Statement for ObservationStatement mutator calls Return proxied Statement from ObservationStatement mutator calls May 28, 2026
mp911de pushed a commit that referenced this pull request May 28, 2026
@BenEfrati @mp911de
Return proxied Statement from ObservationStatement mutator calls.
dd6a362 
Add test to verify proxy preserves Observation

Signed-off-by: Ben Efrati <BenEfrati@users.noreply.github.com>

Closes #1651
Original pull request: #1652
mp911de added a commit that referenced this pull request May 28, 2026
@mp911de
Polishing.
f0d53e9 
Reformat code, refine nullability annotations, simplify test code.

See #1651
Original pull request: #1652
mp911de pushed a commit that referenced this pull request May 28, 2026
@BenEfrati @mp911de
Return proxied Statement from ObservationStatement mutator calls.
a7d509d 
Add test to verify proxy preserves Observation

Signed-off-by: Ben Efrati <BenEfrati@users.noreply.github.com>

Closes #1651
Original pull request: #1652
mp911de added a commit that referenced this pull request May 28, 2026
@mp911de
Polishing.
448245c 
Reformat code, refine nullability annotations, simplify test code.

See #1651
Original pull request: #1652
mp911de pushed a commit that referenced this pull request May 28, 2026
@BenEfrati @mp911de
Return proxied Statement from ObservationStatement mutator calls.
b77c6f9 
Add test to verify proxy preserves Observation

Signed-off-by: Ben Efrati <BenEfrati@users.noreply.github.com>

Closes #1651
Original pull request: #1652
mp911de added a commit that referenced this pull request May 28, 2026
@mp911de
Polishing.
1e38633 
Reformat code, refine nullability annotations, simplify test code.

See #1651
Original pull request: #1652
@mp911de
Copy link
Copy Markdown
Member

mp911de commented May 28, 2026

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this May 28, 2026
@mp911de mp911de added this to the 4.5.12 (2025.0.12) milestone May 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mp911de mp911de

Labels

type: bug A general bug

Projects

None yet

Milestone

4.5.12 (2025.0.12)

Development

Successfully merging this pull request may close these issues.

ObservationRequestTracker remains open for observed Cassandra statements

3 participants

@BenEfrati @mp911de @spring-projects-issues