Replace isAssignableFrom() with isInstance() where feasible#36899
Open
quaff wants to merge 1 commit into
Open
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
reviewed
Jun 11, 2026
This comment was marked as outdated.
This comment was marked as outdated.
sbrannen
added
status: waiting-for-feedback
Contributor
Author
Replace |
spring-projects-issues
added
status: feedback-provided
sbrannen
requested changes
Jun 12, 2026
sbrannen
left a comment
sbrannen
left a comment
Member
There was a problem hiding this comment.
Thanks for making the requested change.
Now I've requested a few additional minor changes.
sbrannen
added
status: waiting-for-feedback
sbrannen
changed the title
isAssignableFrom() with isInstance() where feasible
Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
Contributor
Author
Updated, please review. |
spring-projects-issues
added
status: feedback-provided
sbrannen
added
type: enhancement
sbrannen
requested changes
Jun 12, 2026
sbrannen
left a comment
sbrannen
left a comment
Member
There was a problem hiding this comment.
You missed several of the test assertions. So I've pointed those out as well as some other minor changes.
| public boolean isNotificationEnabled(Notification notification) { | ||
| return AttributeChangeNotification.class.isAssignableFrom(notification.getClass()); | ||
| return notification instanceof AttributeChangeNotification; |
Member
There was a problem hiding this comment.
Suggested change
| return notification instanceof AttributeChangeNotification; | |
| return (notification instanceof AttributeChangeNotification); |
| @Override | ||
| public boolean supports(Object handler) { | ||
| return WebHandler.class.isAssignableFrom(handler.getClass()); | ||
| return handler instanceof WebHandler; |
Member
There was a problem hiding this comment.
Suggested change
| return handler instanceof WebHandler; | |
| return (handler instanceof WebHandler); |
| @Override | ||
| public boolean supports(Object handler) { | ||
| return WebSocketHandler.class.isAssignableFrom(handler.getClass()); | ||
| return handler instanceof WebSocketHandler; |
Member
There was a problem hiding this comment.
Suggested change
| return handler instanceof WebSocketHandler; | |
| return (handler instanceof WebSocketHandler); |
| @Override | ||
| public boolean supports(Object handler) { | ||
| return handler != null && MyHandler.class.isAssignableFrom(handler.getClass()); | ||
| return handler instanceof MyHandler; |
Member
There was a problem hiding this comment.
Suggested change
| return handler instanceof MyHandler; | |
| return (handler instanceof MyHandler); |
| @Override | ||
| public boolean supports(Object handler) { | ||
| return handler != null && MyHandler.class.isAssignableFrom(handler.getClass()); | ||
| return handler instanceof MyHandler; |
Member
There was a problem hiding this comment.
Suggested change
| return handler instanceof MyHandler; | |
| return (handler instanceof MyHandler); |
|
|
||
| assertThat(map).isNotNull(); | ||
| assertThat(MessageHeaders.class.isAssignableFrom(map.getClass())).as("Actual: " + map.getClass()).isTrue(); | ||
| assertThat(map instanceof MessageHeaders).as("Actual: " + map.getClass()).isTrue(); |
Member
There was a problem hiding this comment.
Please convert ALL instanceof and type.isInstance() assertions in this commit to use assertThat(...).isInstance(...).
At a glance there are 7 or more such occurrences in this PR across various test files.
sbrannen
added
the
status: waiting-for-feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.