Preserve I/O errors in RestClient body extraction - #37100
Open
zanarellidev wants to merge 1 commit into
Open
Conversation
readWithMessageConverters wrapped IOException and UncheckedIOException in a RestClientException whose message blamed content-type extraction, hiding timeouts and other I/O failures. Re-throw those as ResourceAccessException (still a RestClientException subclass). Closes spring-projectsgh-37078 Signed-off-by: zanarelli <zanarelli.dev@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DefaultRestClient.readWithMessageConverterswas wrappingIOException/UncheckedIOExceptionasRestClientExceptionwith a content-type extraction message, which made socket timeouts look like conversion failures.I/O causes are now thrown as
ResourceAccessException(already used elsewhere in this class for I/O).HttpMessageNotReadableExceptionkeeps the existing content-type message. Backward compatible for callers catchingRestClientExceptionsinceResourceAccessExceptionextends it.Closes gh-37078
Test plan
DefaultRestClientTestsfor IOException, UncheckedIOException, and HttpMessageNotReadableException paths./gradlew :spring-web:test --tests DefaultRestClientTestsgreen