Use HexFormat instead of custom Hex codec - #19641
Open
therepanic wants to merge 1 commit into
Open
Conversation
Replace internal org.springframework.security.crypto.codec.Hex utility class with standard Java 17 java.util.HexFormat. We already did something similar in this module earlier: 2f53a2e Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
therepanic
commented
Sep 1, 2026
Comment on lines
-85
to
+84
| return new String(Hex.encode(sha(data))); | ||
| return HexFormat.of().formatHex(sha(data)); |
Contributor
Author
There was a problem hiding this comment.
Previously, the string was created without regard for the string pool, but now the string pool is being used. Perhaps it should be wrapped in new String()?
spring-projects-issues
added
the
status: waiting-for-triage
Contributor
Author
|
It also renders #19023 unnecessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace internal
org.springframework.security.crypto.codec.Hexutility class with standard Java 17java.util.HexFormat. We already did something similar in this module earlier: 2f53a2e