Skip to content

test: fix zip(strict=) py3.9 breakage in tri-comparison reconcile test #2372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
squid-protocol merged 1 commit into from
Aug 28, 2026
Merged

test: fix zip(strict=) py3.9 breakage in tri-comparison reconcile test #2372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/tools/test_tri_comparison_reconcile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,10 @@ def test_single_occurrence_name_unchanged(monkeypatch):
_force_rank_pairing(monkeypatch)
rank_result = _reconcile(gg, ts)

for line_scores, rank_scores in zip(line_result[:3], rank_result[:3], strict=True):
assert _rates(line_scores) == _rates(rank_scores)
# _reconcile returns a fixed-shape tuple, so the first 3 elements always
# line up 1:1 -- compare them positionally without zip() (whose strict=
# kwarg is 3.10+ and this repo still supports 3.9).
assert [_rates(s) for s in line_result[:3]] == [_rates(s) for s in rank_result[:3]]


def test_classes_never_use_line_pairing():
Expand Down
Loading