This repository was archived by the owner on Sep 11, 2020. It is now read-only.
Add global and system config support#1243
Open
djgilcrease wants to merge 2 commits intosrc-d:masterfrom
Open
Conversation
djgilcrease
force-pushed
the
feature/gitconfig-support
branch
from
95f48f3 to
33edb07
Compare
djgilcrease
changed the title
Closes src-d#760 Signed-off-by: Dj Gilcrease <d.gilcrease@f5.com>
djgilcrease
force-pushed
the
feature/gitconfig-support
branch
from
33edb07 to
0db6a63
Compare
Signed-off-by: Dj Gilcrease <d.gilcrease@f5.com>
djgilcrease
force-pushed
the
feature/gitconfig-support
branch
from
65f8d1b to
e52680b
Compare
|
Thanks for submitting this PR, @djgilcrease. I would love to have this functionality for a project I'm working on using go-git. It seems that they've moved all development to this repo: https://github.com/go-git/go-git. Can you resubmit this PR over there? |
|
Ran into an issue with this, which I may try to fix and submit an updated PR to the new go-git/go-git repo. Namely, when you load up your config with this code and then later run a |
Author
|
sounds good to me, I am on vacation for the next few weeks so will not be able to do anything with it for a long while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loads the config the same way git does, System, then Global, then Local so overrides are maintained properly.
Closes #760