Skip to content

refactor: Build RBAC with recommended labels#821

Merged
adwk67 merged 11 commits into
mainfrom
feat/smooth-operator/rbac-consolidate-labels
Jul 23, 2026
Merged

refactor: Build RBAC with recommended labels#821
adwk67 merged 11 commits into
mainfrom
feat/smooth-operator/rbac-consolidate-labels

Conversation

@adwk67

@adwk67 adwk67 commented Jul 20, 2026

Copy link
Copy Markdown
Member

Description

Part of: stackabletech/issues#869

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • (Integration-)Test cases added
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67
adwk67 changed the base branch from main to feat/smooth-operator/introduce-builder July 20, 2026 10:44
Base automatically changed from feat/smooth-operator/introduce-builder to main July 21, 2026 15:09
@adwk67 adwk67 self-assigned this Jul 21, 2026
@adwk67
adwk67 force-pushed the feat/smooth-operator/rbac-consolidate-labels branch from 0fbde39 to 6866383 Compare July 21, 2026 15:48
@siegfriedweber
siegfriedweber self-requested a review July 22, 2026 06:53
Comment thread rust/operator-binary/src/controller/mod.rs Outdated
Comment thread rust/operator-binary/src/controller/build/resource/listener.rs Outdated
Comment thread rust/operator-binary/src/controller/build/resource/rbac.rs
Comment thread rust/operator-binary/src/controller/build/resource/rbac.rs
Comment thread rust/operator-binary/src/controller/mod.rs
Comment thread rust/operator-binary/src/controller/mod.rs Outdated
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>

@siegfriedweber siegfriedweber left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adwk67

adwk67 commented Jul 23, 2026

Copy link
Copy Markdown
Member Author
--- PASS: kuttl (492.06s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/smoke_airflow-3.2.2_openshift-false_executor-celery (472.52s)
        --- PASS: kuttl/harness/smoke_airflow-3.2.2_openshift-false_executor-kubernetes (492.04s)
PASS

@adwk67
adwk67 added this pull request to the merge queue Jul 23, 2026
Merged via the queue into main with commit a22eb38 Jul 23, 2026
18 checks passed
@adwk67
adwk67 deleted the feat/smooth-operator/rbac-consolidate-labels branch July 23, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants