Skip to content

fix: scheduler container supervises scheduler instead of dag-processor - #847

Merged
sweb merged 6 commits into
mainfrom
fix/supervise-scheduler
Aug 21, 2026
Merged

fix: scheduler container supervises scheduler instead of dag-processor#847
sweb merged 6 commits into
mainfrom
fix/supervise-scheduler

Conversation

@sweb

@sweb sweb commented Aug 17, 2026

Copy link
Copy Markdown
Member

Description

With Airflow 3, the dag processor was supervised instead of the scheduler in the scheduler container. When the scheduler process died, the pod would not terminate and continue to declare itself as healthy even though nothing would get scheduled.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@sweb
sweb force-pushed the fix/supervise-scheduler branch 2 times, most recently from e1bdc87 to 363fb7c Compare August 17, 2026 09:34
@sweb sweb self-assigned this Aug 17, 2026
@sweb sweb moved this to Development: Waiting for Review in Stackable Engineering Aug 17, 2026
@razvan
razvan self-requested a review August 18, 2026 06:49
@razvan razvan moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Aug 18, 2026
Comment thread rust/operator-binary/src/crd/mod.rs
Comment thread tests/templates/kuttl/cluster-operation/11-assert.yaml Outdated
@sweb
sweb force-pushed the fix/supervise-scheduler branch from c50e548 to 993d5ae Compare August 21, 2026 07:02

@razvan razvan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, assuming the kuttl tests work. didn't run them

@sweb

sweb commented Aug 21, 2026

Copy link
Copy Markdown
Member Author

lgtm, assuming the kuttl tests work. didn't run them

=== NAME  kuttl
    harness.go:406: run tests finished
    harness.go:514: cleaning up
    harness.go:571: removing temp folder: ""
--- PASS: kuttl (4530.10s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/ca-cert_airflow-latest-3.2.2_openshift-false (360.55s)
        --- PASS: kuttl/harness/mount-dags-configmap_airflow-latest-3.2.2_openshift-false_executor-kubernetes (398.98s)
        --- PASS: kuttl/harness/mount-dags-configmap_airflow-latest-3.2.2_openshift-false_executor-celery (245.46s)
        --- PASS: kuttl/harness/versioning_airflow-latest-3.2.2_openshift-false (470.24s)
        --- PASS: kuttl/harness/ldap_airflow-latest-3.2.2_ldap-authentication-server-verification-tls_openshift-false_executor-kubernetes (329.35s)
        --- PASS: kuttl/harness/ldap_airflow-latest-3.2.2_ldap-authentication-server-verification-tls_openshift-false_executor-celery (254.23s)
        --- PASS: kuttl/harness/ldap_airflow-latest-3.2.2_ldap-authentication-no-tls_openshift-false_executor-kubernetes (347.24s)
        --- PASS: kuttl/harness/ldap_airflow-latest-3.2.2_ldap-authentication-no-tls_openshift-false_executor-celery (261.54s)
        --- PASS: kuttl/harness/ldap_airflow-latest-3.2.2_ldap-authentication-insecure-tls_openshift-false_executor-celery (249.98s)
        --- PASS: kuttl/harness/ldap_airflow-latest-3.2.2_ldap-authentication-insecure-tls_openshift-false_executor-kubernetes (339.01s)
        --- PASS: kuttl/harness/overrides_airflow-latest-3.2.2_openshift-false (200.81s)
        --- PASS: kuttl/harness/remote-logging_airflow-latest-3.2.2_openshift-false_executor-kubernetes (351.18s)
        --- PASS: kuttl/harness/opa-interop_airflow-latest-3.2.2_opa-latest-1.16.2_openshift-false (175.59s)
        --- PASS: kuttl/harness/cluster-operation_airflow-latest-3.2.2_openshift-false (267.46s)
        --- PASS: kuttl/harness/external-access_airflow-3.2.2_openshift-false_executor-kubernetes (175.73s)
        --- PASS: kuttl/harness/opa_airflow-3.2.2_opa-latest-1.16.2_openshift-false (221.92s)
        --- PASS: kuttl/harness/external-access_airflow-3.2.2_openshift-false_executor-celery (165.71s)
        --- PASS: kuttl/harness/logging_airflow-3.2.2_openshift-false_executor-celery (279.56s)
        --- PASS: kuttl/harness/remote-logging_airflow-latest-3.2.2_openshift-false_executor-celery (256.03s)
        --- PASS: kuttl/harness/resources_airflow-latest-3.2.2_openshift-false (166.30s)
        --- PASS: kuttl/harness/mount-dags-gitsync_airflow-latest-3.2.2_openshift-false_executor-kubernetes_access-ssh (323.15s)
        --- PASS: kuttl/harness/logging_airflow-3.2.2_openshift-false_executor-kubernetes (616.35s)
        --- PASS: kuttl/harness/orphaned-resources_airflow-latest-3.2.2_openshift-false (329.39s)
        --- PASS: kuttl/harness/triggerer_airflow-latest-3.2.2_openshift-false_executor-kubernetes (247.49s)
        --- PASS: kuttl/harness/triggerer_airflow-latest-3.2.2_openshift-false_executor-celery (237.18s)
        --- PASS: kuttl/harness/mount-dags-gitsync_airflow-latest-3.2.2_openshift-false_executor-celery_access-ssh (353.88s)
        --- PASS: kuttl/harness/mount-dags-gitsync_airflow-latest-3.2.2_openshift-false_executor-kubernetes_access-https (300.72s)
        --- PASS: kuttl/harness/smoke_airflow-3.2.2_openshift-false_executor-celery (345.43s)
        --- PASS: kuttl/harness/smoke_airflow-3.2.2_openshift-false_executor-kubernetes (319.49s)
        --- PASS: kuttl/harness/mount-dags-gitsync_airflow-latest-3.2.2_openshift-false_executor-celery_access-https (234.90s)
        --- PASS: kuttl/harness/oidc_airflow-latest-3.2.2_openshift-false (228.85s)
PASS
2026-08-21 10:54:28 :: Test exited with code 0
2026-08-21 10:54:28 :: 
2026-08-21 10:54:28 :: Waiting 1 minute to allow logs to be processed...
2026-08-21 10:55:28 :: Terminating a cluster named 'ba0b2151ef4442c782f15d4898cb3fa9' on replicated.com...
Archiving artifacts
[description-setter] Description set: k3s on replicated.com (1.36.2)
[Slack Notifications] found #111 as previous completed, non-aborted build
[Slack Notifications] will send OnBackToNormalNotification because build matches and user preferences allow it
Finished: SUCCESS

@sweb
sweb added this pull request to the merge queue Aug 21, 2026
Merged via the queue into main with commit b1c8805 Aug 21, 2026
13 checks passed
@sweb
sweb deleted the fix/supervise-scheduler branch August 21, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: In Review

Development

Successfully merging this pull request may close these issues.

3 participants