refactor: Build RBAC with recommended labels#731
Open
adwk67 wants to merge 8 commits into
Open
Conversation
12 tasks
adwk67
force-pushed
the
feat/smooth-operator/build-rbac
branch
from
July 22, 2026 09:15
809f790 to
1bb0927
Compare
Member
Author
|
siegfriedweber
requested changes
Jul 24, 2026
| /// regression fails here, with a validate-shaped message, instead of surfacing as a confusing | ||
| /// build-test failure downstream. | ||
| #[test] | ||
| fn validate_ok_derives_expected_values() { |
Member
There was a problem hiding this comment.
This test case tests the "happy path". Why are exactly name, namespace, product_version and role group names tested and not other properties of ValidatedCluster?
Comment on lines
+340
to
+349
| #[test] | ||
| fn validate_rejects_missing_metastore_role() { | ||
| let yaml = DERBY_YAML | ||
| .split("metastore:") | ||
| .next() | ||
| .expect("the fixture contains a metastore role"); | ||
|
|
||
| let error = expect_validate_err(yaml); | ||
| assert!(matches!(error, Error::NoMetaStoreRole)); | ||
| } |
Member
There was a problem hiding this comment.
split is a fragile choice. But more important: metastore is required but it is defined as optional for no good reason (see #707 (comment)). I would just fix it instead of adding further code.
If it will be fixed in the future, chances are that this code is forgotten to be removed.
|
|
||
| #[test] | ||
| fn validate_rejects_invalid_role_group_name() { | ||
| let yaml = DERBY_YAML.replace("default:", "Invalid_RG:"); |
Member
There was a problem hiding this comment.
I would prefer to duplicate the YAML instead of using string manipulation. It is not obvious what the test input is.
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of: stackabletech/issues#869
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker