make keystoneURL optional in provider secret#55
Merged
ske-prow[bot] merged 1 commit intomainfrom Mar 19, 2026
Merged
Conversation
ske-prow
bot
added
kind/task
nschad
reviewed
Mar 18, 2026
Contributor
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: 0f55ebfdda2006d173f3085272a172aaf962adc9 |
Contributor
|
/test pull-gardener-extension-provider-stackit-infra-integration-tests |
Member
Author
tested with openstack and stackit shoot in ondemand
|
Member
Author
|
/hold |
ske-prow
bot
added
do-not-merge/hold
breuerfelix
force-pushed
the
keystone
branch
2 times, most recently
from
1dbad7d to
5d71203
Compare
Member
Author
|
/unhold |
ske-prow
bot
removed
the
do-not-merge/hold
nschad
approved these changes
Mar 19, 2026
|
LGTM label has been added. DetailsGit tree hash: 0f55ebfdda2006d173f3085272a172aaf962adc9 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nschad The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ske-prow
bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind task
What this PR does / why we need it:
When running STACKIT-only shoots (which is the default currently), the ensurer still requires to set a keystone URL which is not needed anymore.
This PR makes it optionally, if its configured -> set it, otherwhise -> just ignore it.
Unfortunately we cannot use the
isSTACKITOnly()check here since we do not have theControlPlaneConfigat hand.If we only check if STACKITMCM and STACKIT infra flow is enabled, and ignore the keystone URL if these are set, it could still be that we use the openstack CSI driver and hence we need the keystone URL.
Making it optionally will keep it working in our environment (tho not enforcing) while not enforcing it for others.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Breaking changes: