feat: integrate vpc in network#1575
Draft
cah-hbaum wants to merge 1 commit into
Draft
Conversation
cah-hbaum
force-pushed
the
feat/vpc-network
branch
from
a1bd221 to
401005b
Compare
rubenhoenle
requested changes
Jul 9, 2026
rubenhoenle
left a comment
rubenhoenle
left a comment
Member
There was a problem hiding this comment.
Rejecting because
- implementation of acc tests is missing
- only the schema is added, but you also have to send the values to the API and write the API response back to the Terraform state
| "vpc_id": schema.StringAttribute{ | ||
| Description: "The ID of the VPC the network is associated with.", | ||
| Optional: true, | ||
| Computed: true, |
Member
There was a problem hiding this comment.
Why is this set to computed? 😅
Author
There was a problem hiding this comment.
Removed the Computed part (youre right that its not required here)
cah-hbaum
force-pushed
the
feat/vpc-network
branch
from
401005b to
b637063
Compare
Integrate the vpc data into the network resource. Signed-off-by: Hannes Baum <hannes.baum@cloudandheat.com>
cah-hbaum
force-pushed
the
feat/vpc-network
branch
from
b637063 to
48b51dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrate the vpc data into the network resource.
Description
relates to #1234
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)