Conversation
When token exchange middleware is configured, it handles its own
Authorization header injection. The oauth-token-injection middleware
was being added anyway, potentially overwriting the exchanged token
with the original OAuth token.
Add hasTokenExchangeMiddleware() to detect when token exchange is
present and skip adding the redundant token injection middleware.
Also fix the middleware name in proxy.go to use the MiddlewareType
constant for consistent detection.
In practical terms what this enables is easier testing with:
```
thv run \
--token-exchange-audience 'backend' \
--token-exchange-client-id blablabla \
--token-exchange-client-secret foobar \
--token-exchange-scopes 'backend-api:read' \
--token-exchange-url https://blah \
--remote-auth-bearer-token-file $(pwd)/token.auth \
```
What the fix enables is to read the token using the remote-auth
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3385 +/- ##
==========================================
- Coverage 64.90% 64.78% -0.13%
==========================================
Files 375 375
Lines 36599 36631 +32
==========================================
- Hits 23755 23731 -24
- Misses 10980 11027 +47
- Partials 1864 1873 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yrobla
approved these changes
Jan 22, 2026
github-actions bot
added a commit
that referenced
this pull request
Jan 22, 2026
This commit bumps the Helm chart version from 0.5.25 to 0.5.26 and updates the appVersion from v0.7.2 to v0.8.0 to align with the updated container images (operator, proxyrunner, and vmcp). The chart README has been regenerated using helm-docs to reflect the new version. Co-authored-by: Juan Antonio Osorio <JAORMX@users.noreply.github.com>
dmjb
pushed a commit
that referenced
this pull request
Jan 23, 2026
* Update toolhive images to v0.8.0 * Skip token injection when token exchange active (#3385) This commit bumps the Helm chart version from 0.5.25 to 0.5.26 and updates the appVersion from v0.7.2 to v0.8.0 to align with the updated container images (operator, proxyrunner, and vmcp). The chart README has been regenerated using helm-docs to reflect the new version. Co-authored-by: Juan Antonio Osorio <JAORMX@users.noreply.github.com> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Juan Antonio Osorio <JAORMX@users.noreply.github.com>
therealnb
pushed a commit
that referenced
this pull request
Jan 23, 2026
* Update toolhive images to v0.8.0 * Skip token injection when token exchange active (#3385) This commit bumps the Helm chart version from 0.5.25 to 0.5.26 and updates the appVersion from v0.7.2 to v0.8.0 to align with the updated container images (operator, proxyrunner, and vmcp). The chart README has been regenerated using helm-docs to reflect the new version. Co-authored-by: Juan Antonio Osorio <JAORMX@users.noreply.github.com> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Juan Antonio Osorio <JAORMX@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When token exchange middleware is configured, it handles its own Authorization header injection. The oauth-token-injection middleware was being added anyway, potentially overwriting the exchanged token with the original OAuth token.
Add hasTokenExchangeMiddleware() to detect when token exchange is present and skip adding the redundant token injection middleware. Also fix the middleware name in proxy.go to use the MiddlewareType constant for consistent detection.
In practical terms what this enables is easier testing with:
What the fix enables is to read the token using the remote-auth