Closed
Conversation
This PR integrates the optimizer into the vMCP server, enabling semantic tool discovery at runtime. Changes include: - Update server.go to use CreateOptimizerToolsFromProvider - Wire optimizer initialization in CLI commands.go - Add operator controller support for optimizer config - Update vmcpconfig converter for optimizer settings - Update capability_adapter for optimizer integration - Add server optimizer_test.go - Build system updates in Taskfile.yml - Delete dummy_optimizer.go (replaced by EmbeddingOptimizer) - Update health checker and monitor for optimizer support - Update test files for integration changes This is part 2 of a 3-part PR split. Depends on PR1 (optimizer packages). Part 3 will add documentation and examples.
2 tasks
Contributor
There was a problem hiding this comment.
Large PR Detected
This PR exceeds 1000 lines of changes and requires justification before it can be reviewed.
How to unblock this PR:
Add a section to your PR description with the following format:
## Large PR Justification
[Explain why this PR must be large, such as:]
- Generated code that cannot be split
- Large refactoring that must be atomic
- Multiple related changes that would break if separated
- Migration or data transformationAlternative:
Consider splitting this PR into smaller, focused changes (< 1000 lines each) for easier review and reduced risk.
See our Contributing Guidelines for more details.
This review will be automatically dismissed once you add the justification section.
6 tasks
Contributor
|
Closing, since this will be replaced by the linked tasks above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR integrates the optimizer into the vMCP server, enabling semantic tool discovery at runtime.
This is part 2 of a 3-part PR split from #3440:
Depends on: #3516 (PR 1)
Changes
Server Integration
server.goto useCreateOptimizerToolsFromProvidercapability_adapter.gooptimizer supportpkg/vmcp/server/optimizer_test.goCLI Integration
cmd/vmcp/app/commands.goOperator Integration
vmcpconfig/converter.gofor optimizer settingsBuild System
Taskfile.ymlwith optimizer build flagsCleanup
dummy_optimizer.go(replaced byEmbeddingOptimizer)dummy_optimizer_test.goTest Updates
Test Plan