Add omitempty to MCPGroupStatus JSON fields#5181
Open
sharanrajt wants to merge 1 commit intostacklok:mainfrom
Open
Add omitempty to MCPGroupStatus JSON fields#5181sharanrajt wants to merge 1 commit intostacklok:mainfrom
sharanrajt wants to merge 1 commit intostacklok:mainfrom
Conversation
Add omitempty to servers and serverCount JSON tags in MCPGroupStatus so optional fields are omitted from serialized output when empty, consistent with other optional fields in the struct. Fixes stacklok#4537 Signed-off-by: Sharan Raj T <sharanrajtm@gmail.com>
sharanrajt
requested review from
ChrisJBurns,
JAORMX,
jerm-dro,
jhrozek and
yrobla
as code owners
jhrozek
approved these changes
May 6, 2026
Contributor
jhrozek
left a comment
jhrozek
left a comment
There was a problem hiding this comment.
The patch is trivial and doesn't change the wire format.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5181 +/- ##
==========================================
- Coverage 67.58% 67.54% -0.05%
==========================================
Files 602 602
Lines 61119 61119
==========================================
- Hits 41308 41280 -28
- Misses 16690 16718 +28
Partials 3121 3121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4537
Summary
Fixes #
Type of change
Test plan
task test)task test-e2e)task lint-fix)