Skip to content

Fix comment and skills#4

Merged
janisz merged 2 commits into
mainfrom
fix_comment_and_skulls
May 8, 2026
Merged

Fix comment and skills#4
janisz merged 2 commits into
mainfrom
fix_comment_and_skulls

Conversation

@janisz
Copy link
Copy Markdown
Collaborator

@janisz janisz commented May 7, 2026

Enhance ACS Triage Workflow: Skills Integration and Comprehensive Commenting

Summary

Two improvements to the ACS triage workflow to increase visibility and leverage reusable skills:

  1. Clone stackrox/skills repository during setup - Makes reusable ACS-specific skills available for triage analysis
  2. Comment on ALL issues when using --comment flag - Previously only commented on high-confidence issues (≥70-80%), now comments on all
    triaged issues with low-confidence warnings

Motivation

Skills Repository Integration

The stackrox/skills repository contains specialized analysis tools (like rhacs-patch-eval for VEX analysis) that can improve triage
accuracy. By cloning this repo during setup, the workflow can leverage these skills on-demand.

Comprehensive Commenting

The previous behavior of only commenting on high-confidence issues meant that low-confidence assignments were invisible to teams in JIRA.
This created a gap where automated triage analysis existed but wasn't shared. Teams now see analysis for all issues, with clear warnings when
confidence is low.

janisz and others added 2 commits May 7, 2026 11:40
Two key improvements to the triage workflow:

1. Clone stackrox/skills repository during setup phase
   - Added to Phase 1a setup alongside stackrox/stackrox
   - Makes reusable skills available (rhacs-patch-eval, etc.)
   - Updated reference/constants.md with skills repo path

2. Comment on ALL issues when --comment flag is used
   - Previously: only commented on issues with confidence ≥70-80%
   - Now: comments on all triaged issues regardless of confidence
   - Low confidence (<80%) issues get ⚠️ warning for manual review
   - Ensures all triaged issues receive analysis feedback

Updated files:
- .claude/commands/triage.md: Phase 1a and Phase 7 updated
- .claude/commands/comment-issues.md: Removed confidence filtering
- CLAUDE.md: Updated command descriptions
- README.md: Updated workflow phases
- reference/constants.md: Added skills repository path

This ensures teams see triage analysis on all issues, not just
high-confidence ones, improving visibility of the automated process.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Code quality improvements from /simplify review:

1. Add low confidence warning threshold to constants
   - Defined 80% threshold in reference/constants.md
   - Removed magic number from multiple locations

2. Remove redundant behavior description
   - Consolidated --comment flag behavior into options list
   - Eliminated duplicate explanation

3. Remove deprecated field documentation
   - Removed vuln_analysis.component (marked deprecated)
   - Use language + package_name instead

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@janisz janisz changed the title Fix comment and skulls Fix comment and skills May 7, 2026
@janisz janisz requested a review from mtodor May 7, 2026 10:29
@janisz janisz merged commit 7e9b4f1 into main May 8, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants