Conversation
porridge
changed the title
The credential provider binary needs a real OS (not scratch), so select the -distro image variant automatically. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-Off-By: Marcin Owsiany <porridge@redhat.com>
vladbologa
approved these changes
May 11, 2026
| docker manifest push "${tag}" | ||
| done | ||
|
|
||
| # Distro-full "FROM debian:stable-slim" images. |
Comment on lines
+60
to
+61
| // If distro is true, appends "-distro" to the result. | ||
| func processVersion(version string, distro bool) string { |
There was a problem hiding this comment.
Suggested change
| // If distro is true, appends "-distro" to the result. | |
| func processVersion(version string, distro bool) string { | |
| // If useDistroImage is true, appends "-distro" to the result. | |
| func processVersion(version string, useDistroImage bool) string { |
nit: thought that distro is a bit cryptic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
FROM scratchimage does not contain libraries that the GKE credential plugin needs:plugin execution failed: fork/exec /tmp/credential-provider-bin/auth-provider-gcp: no such file or directory, stderr:gke-latest-...job succeeded must have been some kind of fluke 🤷🏻 In fact that problematic test case didn't seem to run at all:What this does
This PR adds a parallel set of images differing only in base image, they are about twice the size of the
FROM scratchones. It also changes the deploy tool to use them transparently when credential plugin integration is enabled.Additionally, it changes the auth data passing to resemble the way kubelet does it more - in particular it drops the server endpoint piece which somehow prevents CRI from fetching the image:
Testing