Closed
Conversation
Signed-off-by: cyc60 <avsysoev60@gmail.com>
Signed-off-by: cyc60 <avsysoev60@gmail.com>
Signed-off-by: cyc60 <avsysoev60@gmail.com> # Conflicts: # src/common/abi/INodesManager.json # src/config/networks.py
Contributor
There was a problem hiding this comment.
Pull request overview
Adds NodesManager-based validator registration/funding flow to the operator, wiring new NodeManager tasks/oracle polling + CLI startup integration, and exposes existing deposit/funding-amount helpers for reuse.
Changes:
- Rename internal validator-amount helper functions to public
get_deposits_amounts/get_funding_amountsand update call sites/tests. - Introduce NodeManager module: dataclass typings, oracle request/approval polling, tx submission helpers, and a periodic
NodeManagerTaskthat funds compounding validators then registers new ones. - Add
node-manager-startCLI options/startup logic (keystore/wallet inputs, DB setup, event sync, oracle cache warmup) plus initial pytest coverage.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/validators/tests/test_tasks.py | Updates tests to use newly public helper function names. |
| src/validators/tasks.py | Renames _get_* helpers to get_* and updates internal call sites. |
| src/node_manager/typings.py | Adds request/approval dataclasses for NodesManager oracle flows. |
| src/node_manager/tests/test_tasks.py | Adds tests for NodeManagerTask orchestration paths. |
| src/node_manager/tests/test_register_validators.py | Adds tests for NodesManager tx submission helper behaviors. |
| src/node_manager/tests/test_oracles_http.py | Adds HTTP-level tests for NodesManager oracle endpoints. |
| src/node_manager/tests/test_oracles.py | Adds unit tests for parsing/combining oracle approvals and request building. |
| src/node_manager/tests/init.py | Initializes node_manager test package. |
| src/node_manager/tasks.py | Implements NodeManagerTask: eligibility polling + funding + registration. |
| src/node_manager/register_validators.py | Implements register_validators / fund_validators / _submit_tx for NodesManager contract calls. |
| src/node_manager/oracles.py | Implements NodesManager oracle polling, request building, parsing, and approval aggregation. |
| src/commands/node_manager_start.py | Adds NodeManager operator start command options and startup wiring. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: cyc60 <avsysoev60@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.