some refactors to make the code more readable#136
Open
JayceFayne wants to merge 2 commits intostaktrace:masterfrom
Open
some refactors to make the code more readable#136JayceFayne wants to merge 2 commits intostaktrace:masterfrom
JayceFayne wants to merge 2 commits intostaktrace:masterfrom
Conversation
Merged
staktrace
reviewed
Jan 31, 2026
Owner
staktrace
left a comment
There was a problem hiding this comment.
Thanks! Overall this is a nice cleanup. I'd prefer to drop the second commit but the other three look good
added 2 commits
February 1, 2026 11:34
Author
|
Dropped the second commit |
Owner
|
Please rebase and resolve conflicts here. Thanks again for all the PRs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this PR was to parse embedded rfc822 messages (eagerly).
For example:
Is not being parsed but instead you get a binary body...which is fine.
It turns out adding this feature would just add unneccesarry complexity. I am opening this PR to upstream some refactors that make the
parse_mail_recursivefunction much more readable.