Skip to content

Conversation

@BjarkeHautop
Copy link
Contributor

This PR fixes all the size warnings that ggplot2 threw (see also issue #408) by replacing them with linewidth.

I also added size as deprecated in ppc_km_overlay() and p_overlay() using lifecycle::deprecated.

…ted arg size and added linewidth as new preferred arg where it made sense.
@jgabry
Copy link
Member

jgabry commented Jan 5, 2026

Thank you! I definitely think we should change all internal cases of this. For the user-facing arguments, is there a reason only to do this for plots in ppc-censoring.R? For example, mcmc_trace() also has a user-facing size argument for controlling line width and I would guess that other functions do too (I haven't done a thorough check recently).

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.62%. Comparing base (5a5b1e5) to head (e2b62b9).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #414   +/-   ##
=======================================
  Coverage   98.61%   98.62%           
=======================================
  Files          35       35           
  Lines        5792     5798    +6     
=======================================
+ Hits         5712     5718    +6     
  Misses         80       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BjarkeHautop
Copy link
Contributor Author

BjarkeHautop commented Jan 6, 2026

For the user-facing arguments, is there a reason only to do this for plots in ppc-censoring.R? For example, mcmc_trace() also has a user-facing size argument for controlling line width and I would guess that other functions do too (I haven't done a thorough check recently).

No, we should probably do that. But note that some size arguments are still correct, so we can't just replace all size with linewidth without looking at the code.

@jgabry
Copy link
Member

jgabry commented Jan 6, 2026

Do mind removing the the deprecations in the ppc-censoring functions from this PR? Let's handle internal changes in this PR and then we can do the user-facing changes separately. I think that will make it easier to review and reason about. Is that ok with you? Thanks again for working on this!

@BjarkeHautop
Copy link
Contributor Author

No problem! Removed all deprecation stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants