Skip to content

remove extra std::forward in fwd/functor/reduce_sum loop#3323

Open
SteveBronder wants to merge 3 commits into
developfrom
fix/3303-reduce-sum
Open

remove extra std::forward in fwd/functor/reduce_sum loop#3323
SteveBronder wants to merge 3 commits into
developfrom
fix/3303-reduce-sum

Conversation

@SteveBronder
Copy link
Copy Markdown
Collaborator

Summary

Fixes #3303 by removing extra std::forward in fwd/functor/reduce_sum.hpp

Tests

No new tests. I think this is a pretty reasonable potential bug that is just an extra forward reference in a loop.

Checklist

  • Copyright holder: Steve Bronder

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

Copy link
Copy Markdown
Member

@syclik syclik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reduce_sum: std::forward in fwd Loop Moves Shared Args

3 participants