-
-
Notifications
You must be signed in to change notification settings - Fork 1k
docs: improve doctests for ndarray instances in stats/maxsorted
#9385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
Coverage Report
The above coverage report was generated for the changes in this PR. |
Signed-off-by: Athan <[email protected]>
kgryte
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
shouldnt i make the changes ? |
|
@shiavm006 They've already been made. :) |
thanks i didnt checked them out sorry |
|
Thank you for your contribution and congratulations on your first PR! |
thanks |
could u suggest me some more issues on which i can work on ? |
Resolves a part of #9329 .
Description
stats/maxsortedpackage by replacing verbose decomposition logic (using.get()method andndarray2array()function) with the new concise ndarray instance notation<ndarray>[ ... ]ndarray2arrayimports from documentation examplesChecklist
AI Assistance
@stdlib-js/reviewers