Skip to content

Conversation

@Amansingh0807
Copy link
Contributor

Resolves None

Description

What is the purpose of this pull request?

This pull request:

  • This PR adds math/base/special/roundnf.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

  • Resolves None

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Dec 27, 2025
@Amansingh0807 Amansingh0807 marked this pull request as draft December 27, 2025 07:06
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Dec 27, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Dec 27, 2025

Coverage Report

No coverage information available.

@Amansingh0807 Amansingh0807 force-pushed the feat-math-base-special-roundnf branch from 4a794b6 to 15255de Compare December 27, 2025 08:11
@Amansingh0807 Amansingh0807 marked this pull request as ready for review December 27, 2025 08:27
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Dec 27, 2025
@Amansingh0807
Copy link
Contributor Author

Amansingh0807 commented Dec 28, 2025

Hi @kgryte !!
I noticed packages like roundn and others include Python, Julia, and R benchmarks for cross-language performance comparison. Should I add these benchmarks for completeness, or are the current JS/Native benchmarks sufficient for this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants