chore: remove pkg-up dependency#169
Open
innerdvations wants to merge 1 commit into
Open
Conversation
pkg-up is deprecated and its v5 release is ESM-only, which complicates the CJS CLI entrypoint and Jest on Node 22. Inline the same lookup behaviour instead of upgrading the dependency.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg-updependency and inline the same package.json lookup in a smallfindPackageJsonhelperloadPkgcall sites inpkg.tsandpkg-loader.tsto use the helperThis supersedes #159. Upgrading
pkg-upto v5 is not worthwhile: the package is deprecated in favour ofpackage-up, v5 is ESM-only, and the CLI only needed its trivial "walk up to find package.json" behaviour.User impact
No breaking change for plugin authors. This is an internal dependency removal with identical runtime behaviour.
Related issue(s)/PR(s)
Fixes CMS-1100
Test plan
pnpm checkpasses locally (lint, typecheck, unit tests)