fix(nodes): vp9 bindgen#650
Conversation
![staging-devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/870844?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…round Signed-off-by: streamkit-devin <devin@streamkit.dev>
Signed-off-by: streamkit-devin <devin@streamkit.dev>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Signed-off-by: streamkit-devin <devin@streamkit.dev>
There was a problem hiding this comment.
📝 Info: libclang-dev additions consistent across build environments
This PR enables the generate feature on env-libvpx-sys (crates/nodes/Cargo.toml:79), which runs bindgen at build time and therefore requires libclang-dev. The corresponding apt-get install additions were applied to the setup-skit composite action and hosted-runner workflows (e2e.yml, pipeline-validation-nightly.yml, release.yml), and all Dockerfiles already include libclang-dev. The self-hosted GPU jobs (test-gpu in skit.yml, pipeline-validation-gpu in e2e.yml) do not add libclang-dev to their apt steps, but those jobs already rely on a preinstalled LLVM/clang (they set BINDGEN_EXTRA_CLANG_ARGS for shiguredo_nvcodec's bindgen). This is a runner-environment assumption that cannot be verified from the repo, but is consistent with pre-existing behavior. Worth a quick confirmation that the self-hosted runners actually have libclang available for the vp9 build path.
(Refers to lines 168-171)
Was this helpful? React with 👍 or 👎 to provide feedback.
Debug
There was a problem hiding this comment.
Confirmed: the self-hosted GPU jobs (Skit / Test (GPU), E2E / Pipeline Validation (GPU)) already passed on the first run of this PR with generate enabled, so libclang is available on those runners.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #650 +/- ##
==========================================
+ Coverage 85.22% 85.24% +0.01%
==========================================
Files 249 249
Lines 75412 75412
Branches 2437 2314 -123
==========================================
+ Hits 64273 64285 +12
+ Misses 11133 11121 -12
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
2 participants
Summary
fixing vp9 builds on Ubuntu 24.04
Devin Review
8aad6d1