Implementation of Roughness Amplification Factor Transition Model for SST

[marcosch27]

Proposed Changes

Hello everyone,

This PR is one of two contributions resulting from my Master’s Thesis.

In this PR, I’ve added a new roughness-induced transition model through a roughness amplification factor transport (AFT), based on the approach described in this paper by Langel et al.

The attached PDF includes documentation as well as validation results for the NACA0012 transitional test case with roughness strips. Further validation test cases have been performed and are reported in my Master's Thesis, which will be available in the following months. If needed, I can add a validation test case to the SU2 suite.

Please let me know if any modifications are needed.

Related Work

PR Checklist

• I am submitting my contribution to the develop branch.
• My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
• My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
• I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
• I have added a test case that demonstrates my contribution, if necessary.
• I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

[bigfooted]

Thanks for the contribution! So what does the result look like if we do not use this extension?
If you feel generous, please also consider adding some info to the theory section. Many of these models are not visible to the casual user.
https://su2code.github.io/docs_v7/Theory/#turbulence-modeling

[joshkellyjak]

A testcase for these features would be very beneficial also!

[pcarruscag]

Thank you for the contributions 👍 I'll review this PR once the other one is ready to merge.
Add yourself to the AUTHORS.md list.

[pcarruscag]

@marcosch27 the code changes look pretty straightforward, can you add a testcase?
And add yourself to AUTHORS.md.

[pcarruscag]

And update the config_template too

[marcosch27]

@marcosch27 the code changes look pretty straightforward, can you add a testcase? And add yourself to AUTHORS.md.

@pcarruscag Ok I will add the test case related to this PR, and do I need to merge upstream/develop into my current branch to bring in the latest changes from develop?

[pcarruscag]

Yep, merge develop into your branch. I don't think you do, but if you have new files, check that the copyright years and code version are up to date.