Skip to content

♿️(frontend) use heading element for pinned documents section title#2380

Merged
Ovgodd merged 1 commit into
mainfrom
fix/a11y-2349-pinned-doc-title-semantic
Jun 9, 2026
Merged

♿️(frontend) use heading element for pinned documents section title#2380
Ovgodd merged 1 commit into
mainfrom
fix/a11y-2349-pinned-doc-title-semantic

Conversation

@Ovgodd

@Ovgodd Ovgodd commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Purpose

Replace the <span> section title with an <h2> for the "Pinned documents" section in the left panel (LeftPanelFavorites).

Proposal

  • Render "Pinned documents" as <h2> via Text as="h2"
  • Remove aria-labelledby and id="pinned-docs-title" from the <section>
  • Reset heading margin ($margin="0") to preserve the existing visual appearance

@Ovgodd Ovgodd requested a review from AntoLC June 2, 2026 15:00
@Ovgodd Ovgodd self-assigned this Jun 2, 2026
@Ovgodd Ovgodd added bug Something isn't working accessibility labels Jun 2, 2026
@Ovgodd Ovgodd added the triage label Jun 2, 2026
@Ovgodd Ovgodd force-pushed the fix/a11y-2349-pinned-doc-title-semantic branch from 1b19ff3 to 0e81926 Compare June 2, 2026 15:01
@Ovgodd Ovgodd moved this from Backlog to In review in LaSuite Docs A11y Jun 2, 2026
@Ovgodd Ovgodd linked an issue Jun 2, 2026 that may be closed by this pull request
@Ovgodd Ovgodd force-pushed the fix/a11y-2349-pinned-doc-title-semantic branch from 0e81926 to 1667528 Compare June 2, 2026 15:02
@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: e2fe956d-57d2-4445-8b6e-ddd89725f22f

📥 Commits

Reviewing files that changed from the base of the PR and between 98a2085 and a4559d9.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • src/frontend/apps/impress/src/features/left-panel/components/LeftPanelFavorites.tsx

Walkthrough

This PR changes LeftPanelFavorites to render the pinned documents container as a section and the title as a semantic h2 (removing the prior aria-labelledby and title id). It also adds three changelog entries under [Unreleased]: the pinned documents heading change and two backend notes about thread DB connection closure and an UnorderedObjectListWarning fix.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Suggested reviewers

  • AntoLC
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title clearly and specifically describes the main change: converting the pinned documents section title from a span to a semantic heading element (h2) for accessibility.
Description check ✅ Passed The pull request description is directly related to the changeset, providing clear purpose, proposal details with checklist items, and explanation of the accessibility improvement being implemented.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/a11y-2349-pinned-doc-title-semantic

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Size Change: 0 B

Total Size: 4.33 MB

📦 View Changed
Filename Size Change
apps/impress/out/_next/static/12e8596f/_buildManifest.js 0 B -673 B (removed) 🏆
apps/impress/out/_next/static/56492816/_buildManifest.js 673 B +673 B (new file) 🆕

compressed-size-action

@Ovgodd Ovgodd force-pushed the fix/a11y-2349-pinned-doc-title-semantic branch from 1667528 to 74609b4 Compare June 3, 2026 07:13
@Ovgodd Ovgodd force-pushed the fix/a11y-2349-pinned-doc-title-semantic branch from 74609b4 to 98a2085 Compare June 9, 2026 07:22

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CHANGELOG.md`:
- Line 45: Update the changelog entry text by replacing the phrase "sub
documents" with the hyphenated form "sub-documents" in the line containing
"♻️(backend) allow global search in sub documents `#2310`" so it reads
"♻️(backend) allow global search in sub-documents `#2310`".
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 59222501-93fb-4c21-8d3d-62f2537f9ddf

📥 Commits

Reviewing files that changed from the base of the PR and between 74609b4 and 98a2085.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • src/frontend/apps/impress/src/features/left-panel/components/LeftPanelFavorites.tsx

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@CHANGELOG.md`:
- Line 45: Update the changelog entry text by replacing the phrase "sub
documents" with the hyphenated form "sub-documents" in the line containing
"♻️(backend) allow global search in sub documents `#2310`" so it reads
"♻️(backend) allow global search in sub-documents `#2310`".
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 59222501-93fb-4c21-8d3d-62f2537f9ddf

📥 Commits

Reviewing files that changed from the base of the PR and between 74609b4 and 98a2085.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • src/frontend/apps/impress/src/features/left-panel/components/LeftPanelFavorites.tsx
🛑 Comments failed to post (1)
CHANGELOG.md (1)

45-45: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Use hyphenated compound noun in changelog text.

At Line 45, change “sub documents” to “sub-documents” for consistent wording quality.

Suggested patch
-- ♻️(backend) allow global search in sub documents `#2310`
+- ♻️(backend) allow global search in sub-documents `#2310`
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

- ♻️(backend) allow global search in sub-documents `#2310`
🧰 Tools
🪛 LanguageTool

[grammar] ~45-~45: Use a hyphen to join words.
Context: ...- ♻️(backend) allow global search in sub documents #2310 - ✨(backend) add a bread...

(QB_NEW_EN_HYPHEN)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@CHANGELOG.md` at line 45, Update the changelog entry text by replacing the
phrase "sub documents" with the hyphenated form "sub-documents" in the line
containing "♻️(backend) allow global search in sub documents `#2310`" so it reads
"♻️(backend) allow global search in sub-documents `#2310`".

Source: Linters/SAST tools

Replace <span> with <h2> so the section appears in the heading for SR.
@Ovgodd Ovgodd force-pushed the fix/a11y-2349-pinned-doc-title-semantic branch from 98a2085 to a4559d9 Compare June 9, 2026 08:35
@Ovgodd Ovgodd merged commit a4559d9 into main Jun 9, 2026
44 of 45 checks passed
@Ovgodd Ovgodd deleted the fix/a11y-2349-pinned-doc-title-semantic branch June 9, 2026 09:31
@github-project-automation github-project-automation Bot moved this from In review to Done in LaSuite Docs A11y Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility bug Something isn't working triage

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

"Pinned Documents" section: section title without heading semantics

2 participants