Skip to content

Remove the fallback to parsing the HTML when rtd_search_projects is not set #297

Description

@Cadair

Provide a general description of the issue or problem.

This section of the code:

} else {
// Use the documentation nav links
document
.getElementById("Documentation")
.querySelectorAll(".nav-link")
.forEach(function (el) {
// We might want to somehow limit which projects to include in the search
let slug = el.innerHTML.replace(/(^\s|\s$)/, "");
let link = el.getAttribute("href");
_obj.projects[slug] = { name: slug, url: link };
});
this.projectorder = Object.keys(this.projects);
}

Isn't really needed now we have the Python theme configuration.

@slowe How would you recommend we remove this? I think we would need to just fallback to the original sphinx search? I can make the Python configuration raise an error, so it should be unlikely to hit this.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions