docs(release): notes for v2.109.0#5742
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df73728131
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| v2.109.0 moves migration commands to TypeScript with a critical fix for pipeline-incompatible SQL statements, adds `db reset --sql-paths` for CI workflows, and resolves several database operation bugs. | ||
|
|
||
| ### Highlights | ||
| - **Migration files with pipeline-incompatible statements now apply correctly** — `migration up`/`down` now handle `CREATE INDEX CONCURRENTLY`, `VACUUM CONCURRENTLY`, `REINDEX CONCURRENTLY`, `ALTER SYSTEM`, `CLUSTER` without failing. (#5671) |
There was a problem hiding this comment.
List the valid VACUUM statement syntax
For migrations that contain VACUUM statements, the #5671 implementation handles bare VACUUM / VACUUM (...) via legacyIsPipelineIncompatible, not a VACUUM CONCURRENTLY form; VACUUM CONCURRENTLY is not valid Postgres syntax. Publishing this highlight would tell users to expect or write an invalid SQL statement and misdescribe the fix, so it should say VACUUM instead.
Useful? React with 👍 / 👎.
|
|
||
| --- | ||
|
|
||
| Plus N internal improvements and dependency updates. |
There was a problem hiding this comment.
Replace the placeholder internal-change count
When the release-notes workflow applies this file, the GitHub Release body will literally include Plus N internal improvements and dependency updates. The prompt expects N to be replaced with the actual tail count, so leaving the placeholder makes the published notes look unfinished and obscures how many internal/dependency changes were included.
Useful? React with 👍 / 👎.
|
|
||
| ### Bug fixes | ||
| - Declarative schema sync detects stale local Postgres images and suggests restart instead of silently generating broken migrations. (#5646) | ||
| - `db diff` no longer fails when `schema_paths` glob patterns match no files, enabling gradual adoption of declarative schema. (#5702) |
There was a problem hiding this comment.
Qualify when empty schema_paths globs are skipped
The #5702 change only skips empty schema_paths glob entries when other schema files are still found; it still returns an error when all configured globs are empty via WithErrorOnAllSkippedGlobs, and literal missing paths still fail. As written, users with only empty glob patterns will expect db diff to continue, so the note should narrow this to partially-empty glob lists or mention the all-empty exception.
Useful? React with 👍 / 👎.
| ### Bug fixes | ||
| - Declarative schema sync detects stale local Postgres images and suggests restart instead of silently generating broken migrations. (#5646) | ||
| - `db diff` no longer fails when `schema_paths` glob patterns match no files, enabling gradual adoption of declarative schema. (#5702) | ||
| - Fixed `db diff`, `db pull`, and `db schema push` crashing when `supabase/migrations` directory already exists (Windows OneDrive, etc.). (#5724) |
There was a problem hiding this comment.
Name the actual schema sync command
The #5724 fix changed directory creation in db diff, db pull, and db schema declarative sync; repo-wide search shows no db schema push command. Publishing this as db schema push points users at a nonexistent command and misses the affected declarative sync workflow, so the command name should be corrected.
Useful? React with 👍 / 👎.
Proposed user-facing release notes for
v2.109.0, generated byapps/cli/scripts/propose-release-notes.tsagainsttools/release/release-notes-prompt.md.How to update the notes
Edit
release-notes/v2.109.0.mddirectly on this branch — use the GitHub web editor or push commits torelease-notes/v2.109.0— before approving. The applied notes will reflect the file at the approved commit.How to publish
Approve this PR as a
supabase/cliteam member. The.github/workflows/apply-release-notes.ymlworkflow will then:v2.109.0with the contents ofrelease-notes/v2.109.0.md.release-notes/v2.109.0branch.This PR is not merged — the
do not mergelabel is a reminder. It targetsdevelopso that even an accidental merge never rewritesmain. Nothing is meant to land on any branch.Approvals from anyone outside the
supabase/cliteam are ignored; the workflow will post a comment explaining that and leave the release untouched.How to abandon
Close the PR without approving. The auto-generated semantic-release body for
v2.109.0stays in place.Re-generation
After this PR is closed, rerun the Propose release notes workflow from the Actions tab against
v2.109.0to get a fresh proposal.