fix(super-editor): flip toolbar tooltip below the trigger when it clips the viewport top - #3838
Closed
hitpopdimestop wants to merge 3 commits into
Closed
Conversation
…he viewport top Tooltips were always positioned above the trigger, so buttons in a toolbar flush with the window top rendered tooltips off-screen (negative top). Flip the tooltip below the trigger (with the arrow pointing up) when there is no room above. Fixes superdoc-dev#3786
…idth Use document.documentElement.clientWidth instead of window.innerWidth so a tooltip near the right edge does not clamp under a window scrollbar.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Contributor
|
Thanks for the contribution, @hitpopdimestop! I confirmed the issue, but this PR targets v1 and we’re focusing development on v2. The same issue still exists in v2, so we’d be happy to review an updated PR against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Toolbar tooltips were clipped when the toolbar sits flush with the window top. The tooltip was always placed above the trigger, so
triggerRect.top - contentHeight - 10went negative and rendered above the viewport edge (issue #3786).It now:
document.documentElement.clientWidth, which excludes the window scrollbar.Screenshots
Before — the "Insert table" tooltip is clipped at the window top:
After — the tooltip flips below the button:
Test plan
SdTooltip.test.js: flip-below, stay-above, a realistic-height flip (proves the tooltip's height is used, not just when the trigger touches the top), and aclientWidth < innerWidthhorizontal-clamp test.Closes #3786