feat: "On this page" navigation sub-sections #1709
Open
+54
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tmarnet is attempting to deploy a commit to the Svelte Team on Vercel. A member of the Team first needs to authorize it. |
tmarnet
force-pushed
the
on-this-page-subsections
branch
2 times, most recently
from
79ba391 to
9027fae
Compare
tmarnet
force-pushed
the
on-this-page-subsections
branch
from
9027fae to
c419c88
Compare
tmarnet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to display sub-sections inside the "On this page" navigation of the docs, e.g.:
This is motivated by the fact that some of the sections (such as the remote functions "form" above) can get really big and hard to navigate (because it requires lots of scrolling and that you know what you are looking for).
On large screens the sub-sections are only displayed if the parent section is active. On small screens, when togging the menu, they are always displayed. These are the behaviours that made the most sense to me, but do let me know if you feel like we should do it differently.