Feature/method get transaction only returns in wallet transactions#111
Merged
bridgedragon merged 15 commits intoswapper-org:stagingfrom Mar 2, 2022
Conversation
added 13 commits
February 28, 2022 16:43
0xp3gasus
reviewed
Mar 1, 2022
0xp3gasus
reviewed
Mar 1, 2022
0xp3gasus
reviewed
Mar 1, 2022
0xp3gasus
reviewed
Mar 1, 2022
| value = inputTransaction["decoded"]["vout"][vin["vout"]]["value"] | ||
| vinAddressBalances[address] = value | ||
| # Converting all transaction details to str | ||
| transactionDetails["fee"] = str(transactionDetails["fee"]) |
Collaborator
There was a problem hiding this comment.
No need to store the string value, just return the string value in response variable, "fee":str(transactionDetails["fee"])
Collaborator
Author
There was a problem hiding this comment.
I disagree with this, because we are converting all elements in the array at once. I do not want to mix str variables with not-str ones in the same array.
Collaborator
There was a problem hiding this comment.
The thing is that the behaviour is the same if you delete this line and add "fee":str(transactionDetails["fee"]) in line 434
phoenix-web3
requested changes
Mar 1, 2022
Collaborator
phoenix-web3
left a comment
There was a problem hiding this comment.
After the requested changes of @swapper-pegasus this can be merged
Thanks @bridgedragon , beautiful code!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The method getTransaction has been standardized to be run for any transaction (not only in-wallet ones).
Fixes #88
Dependencies (if any)
Type of change
Good practices to consider