Skip to content

Add support for Pkl syntax highlighting#988

Merged
mportiz08 merged 5 commits intoswiftlang:mainfrom
bioball:add-pkl-highlighting
Jan 21, 2026
Merged

Add support for Pkl syntax highlighting#988
mportiz08 merged 5 commits intoswiftlang:mainfrom
bioball:add-pkl-highlighting

Conversation

@bioball
Copy link
Copy Markdown
Contributor

@bioball bioball commented Dec 16, 2025

Bug/issue #, if applicable: #950 (166564627)

Summary

This adds syntax highlighting for Pkl source blocks!

Dependencies

This introduces a new NPM dependency: @apple/highlightjs-pkl

Testing

A new test is added for Pkl-based syntax highlighting.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran npm test, and it succeeded
  • Updated documentation if necessary (I don't see any relevant place to add documentation for this)

Copy link
Copy Markdown
Contributor

@mportiz08 mportiz08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

As we discussed offline, there's one last thing I want to check before merging this, but the changes look great to me—much appreciated :)

Comment thread src/utils/custom-highlight-lang/pkl.js Outdated
bioball and others added 2 commits December 16, 2025 11:12
@heckj
Copy link
Copy Markdown
Member

heckj commented Dec 17, 2025

@swift-ci please test

@mportiz08 mportiz08 requested a review from marinaaisa as a code owner January 21, 2026 21:21
Copy link
Copy Markdown
Contributor

@mportiz08 mportiz08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bioball can you update the NOTICE.txt file with a section for the new dependency?

Once that's done, this looks good to merge—apologies for the delay!

@mportiz08
Copy link
Copy Markdown
Contributor

@swift-ci test

@mportiz08 mportiz08 merged commit 0d77942 into swiftlang:main Jan 21, 2026
1 check passed
@bioball bioball deleted the add-pkl-highlighting branch January 21, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants