Conversation
0a2aea4 to
c005917
Compare
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Tested roughly against this plan. After some time my issue with ln payment disappeared - so in the end I was able to send lightning to contact - still may be worth looking into it. Have some more testing notes below, but mostly that's polishing. Tested against staging. Areas tested and 🟢 for me.
Some testing notes / observations:
Screen.Recording.2026-05-05.at.12.16.38.mov
|
There was a problem hiding this comment.
LGTM
Didn't encounter any other issue except for the ones that Piotr mentioned, and the pay to iOS not working in that exceptional case when actually the issue was on the iOS side. Once I 'restored' my profile on iOS, paying to the contact via Android worked.
PS. Recording of how send 2 contact via Send → Paste behaves (issue reported by Piotr):
https://github.com/user-attachments/assets/2fa3a110-a80c-47b2-861a-65f173252684
piotr-iohk
left a comment
There was a problem hiding this comment.
LGTM, remaining obesrvations can be addressed separately, issue for tracking: #931
fix: refine public Paykit contact handling
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8a5c5734d1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Merging this to master 🎉 🚀 . Thanks team 🙋🏻 |


Description
Adds public Paykit payments to contacts on Android, matching the iOS public payments flow and the Paykit endpoint identifier spec.
Preview
N/A
QA Notes
Suggested reviewer checks:
Sent to {name}/Received from {name}titles.