Skip to content

chore: improve trezor dashboard#939

Open
ovitrif wants to merge 19 commits into
feat/trezor-hardware-supportfrom
feat/trezor-hardware-support-fixes
Open

chore: improve trezor dashboard#939
ovitrif wants to merge 19 commits into
feat/trezor-hardware-supportfrom
feat/trezor-hardware-support-fixes

Conversation

@ovitrif
Copy link
Copy Markdown
Collaborator

@ovitrif ovitrif commented May 11, 2026

Description

This PR:

  1. Addresses the remaining review feedback from feat: trezor hardware support #792.
  2. Propagates Trezor repository, reconnect, credential, and BLE failures instead of silently swallowing them.
  3. Updates Trezor UI-facing state collections to immutable collections and adds the missing changelog fragment.

Preview

N/A

QA Notes

Manual Tests

Automated Checks

  • ./gradlew compileDevDebugKotlin
  • ./gradlew testDevDebugUnitTest
  • ./gradlew detekt

Comment thread app/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
Comment thread app/src/main/java/to/bitkit/repositories/TrezorRepo.kt Outdated
@ovitrif ovitrif self-assigned this May 11, 2026
@ovitrif ovitrif modified the milestones: 2.3.0, 2.4.0 May 11, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1750d15a1d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt
Comment thread app/src/main/java/to/bitkit/ui/screens/trezor/TrezorViewModel.kt Outdated
@ovitrif ovitrif changed the title fix: address trezor review comments fix: improve trezor dashboard May 17, 2026
@ovitrif ovitrif changed the title fix: improve trezor dashboard chore: improve trezor dashboard May 17, 2026
@ovitrif ovitrif force-pushed the feat/trezor-hardware-support-fixes branch from 082436c to b49e879 Compare May 17, 2026 18:21
@ovitrif ovitrif force-pushed the feat/trezor-hardware-support branch from 42b92f7 to 280c4e7 Compare May 17, 2026 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant