Skip to content

chore: bump github.com/21-dot-dev/swift-secp256k1 from 0.17.0 to 0.23.2 in the swift group #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dependabot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: bump github.com/21-dot-dev/swift-secp256k1 from 0.17.0 to 0.23.2 in the swift group #710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Bitkit.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1230,7 +1230,7 @@
repositoryURL = "https://github.com/21-DOT-DEV/swift-secp256k1";
requirement = {
kind = exactVersion;
version = 0.17.0;
version = 0.23.2;

@jvsena42 jvsena42 Sep 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 0.17.0 -> 0.23.2 crosses the 0.20.0 module rename; the app no longer builds

CI fails with Missing package product 'secp256k1' in Bitkit, BitkitTests and BitkitNotification. 0.20.0 renamed secp256k1 -> P256K and secp256k1_bindings -> libsecp256k1, and 0.23.2 no longer re-exports the C bindings. Needed alongside this bump: import P256K (+ P256K.KeyAgreement.*) in Crypto.swift and WatchOnlyAccountService.swift, import libsecp256k1 for the raw secp256k1_* calls in Crypto.swift, and the pbxproj product refs switched to P256K and libsecp256k1 for all three targets. Do this as a manual bump, not a dependabot merge, and re-run WatchOnlyAccountServiceTests plus a push-notification decrypt before shipping.

};
};
/* End XCRemoteSwiftPackageReference section */
Expand Down
4 changes: 2 additions & 2 deletions Bitkit.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading