chore: enforce figma links in relevant prs - #734
Conversation
This comment has been minimized.
This comment has been minimized.
jvsena42
left a comment
There was a problem hiding this comment.
Both greptile findings and my parity note are closed — thanks.
The screens-map reference is gone repo-wide: git grep -E "screens-map|screens map|ltqvnKiejWj0JQiqtDf2JJ|figma\.com" at head returns zero hits, and the only Figma pointers are the three Bitkit - Handoff vNN mentions this PR adds. That was the right of the two options — the artifact didn't exist here. release.md:129-131 has ### Design, and the reviewer clauses now sit in pr.md:121-123 as well as AGENTS.md:347-349.
Minor, not worth changing on its own: the handoff page is named but no file key or URL travels with it, unlike the Android side which pins ltqvnKiejWj0JQiqtDf2JJ in docs/screens-map.md:3. Reaching the page still needs knowledge held outside the repo.
One thing Android fixed in its twin that this still carries — inline.
Cross-repo framing that's more useful than either note alone: Android's follow-up went the opposite direction. It closed the N/A loophole but narrowed its design case to mapped *Screen.kt only, dropping 44 sheets out of coverage. This repo's scope is the better one — it covers sheets, views, anything with a design — it just needs the exemption tightened. Between the two PRs, each has the half the other wants.
jvsena42
left a comment
There was a problem hiding this comment.
936b439e applies exactly the scoping I suggested, on both surfaces — AGENTS.md:348 and .agents/commands/pr.md:122 now read `N/A — no UI changes.` needs no review request; `N/A — no design available.` may receive the single advisory clarification. The self-declared branch is no longer blanket-exempt, which was the whole point. Thanks.
I also checked the two literal strings match byte-for-byte (em dash, trailing period) across every surface that emits or consumes them — .github/pull_request_template.md:15-16, AGENTS.md:343-344, .agents/commands/pr.md:117-118, and the release generator at .agents/commands/release.md:129-131. pr.md builds its body from the template and those two are the only PR-body generators in the tree, so no path can now emit a body without ### Design.
Nothing further from me.
Closes #731
Description
This PR:
N/Aguidance.Linked Issues/Tasks
Design
N/A — no UI changes.
Preview
N/A — no user-visible changes.
QA Notes
Manual Tests
N/A
Automated Checks
git diff --checkpassed.