Skip to content

chore: do some unused code cleanup#29

Merged
tembleking merged 2 commits intomasterfrom
chore-do-some-code-cleanup
Nov 26, 2025
Merged

chore: do some unused code cleanup#29
tembleking merged 2 commits intomasterfrom
chore-do-some-code-cleanup

Conversation

@tembleking
Copy link
Copy Markdown
Member

No description provided.

@tembleking tembleking self-assigned this Nov 26, 2025
@tembleking tembleking requested a review from Copilot November 26, 2025 09:11
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes unused code and types across the codebase, reorganizes imports, and improves error handling. The changes focus on cleaning up dead code while maintaining functionality.

Key changes:

  • Removed unused Vulnerabilities type and its implementation from image scanner
  • Enhanced error handling in command generation with proper Result types
  • Cleaned up unused imports and reorganized module declarations in main.rs

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/main.rs Reorganized imports to use crate:: prefix and added explicit module declarations
src/lib.rs Removed global #![allow(dead_code)] attribute
src/infra/mod.rs Removed unused type exports (ImageInstruction, Instruction) from public API
src/infra/compose_ast_parser.rs Added Error derive and error message to ParseError enum
src/domain/mod.rs Added module-level #![allow(dead_code)] attribute
src/app/mod.rs Removed unused Vulnerabilities export
src/app/lsp_server/mod.rs Removed unused Range import and CommandInfo struct
src/app/lsp_server/lsp_server_inner.rs Improved error handling to properly convert parse errors to JSON-RPC errors
src/app/lsp_server/command_generator.rs Changed return type to Result for proper error propagation
src/app/image_scanner.rs Removed unused Vulnerabilities struct and its From<ScanResult> implementation
src/app/image_builder.rs Added #[allow(dead_code)] for image_id field with FIXME comment
src/app/document_database.rs Removed unused remove_document method and its test, simplified vector syntax

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@tembleking tembleking enabled auto-merge (squash) November 26, 2025 09:13
@tembleking tembleking merged commit cfaf3c2 into master Nov 26, 2025
5 checks passed
@tembleking tembleking deleted the chore-do-some-code-cleanup branch November 26, 2025 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants