Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes unused code and types across the codebase, reorganizes imports, and improves error handling. The changes focus on cleaning up dead code while maintaining functionality.
Key changes:
- Removed unused
Vulnerabilitiestype and its implementation from image scanner - Enhanced error handling in command generation with proper Result types
- Cleaned up unused imports and reorganized module declarations in main.rs
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main.rs | Reorganized imports to use crate:: prefix and added explicit module declarations |
| src/lib.rs | Removed global #![allow(dead_code)] attribute |
| src/infra/mod.rs | Removed unused type exports (ImageInstruction, Instruction) from public API |
| src/infra/compose_ast_parser.rs | Added Error derive and error message to ParseError enum |
| src/domain/mod.rs | Added module-level #![allow(dead_code)] attribute |
| src/app/mod.rs | Removed unused Vulnerabilities export |
| src/app/lsp_server/mod.rs | Removed unused Range import and CommandInfo struct |
| src/app/lsp_server/lsp_server_inner.rs | Improved error handling to properly convert parse errors to JSON-RPC errors |
| src/app/lsp_server/command_generator.rs | Changed return type to Result for proper error propagation |
| src/app/image_scanner.rs | Removed unused Vulnerabilities struct and its From<ScanResult> implementation |
| src/app/image_builder.rs | Added #[allow(dead_code)] for image_id field with FIXME comment |
| src/app/document_database.rs | Removed unused remove_document method and its test, simplified vector syntax |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
alecron
approved these changes
Nov 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.