Update configuration/options summary in svg#61
Merged
keszybz merged 1 commit intosystemd:mainfrom Feb 15, 2025
Merged
Conversation
Some of the comments summarizing the configuration/options could be confusing. E.g., "f" was used for "Filtering", but "-f" is the command-line option used to specify the sample frequency. Also, "hz" was used but there is no command-line option or config directive that mentions "hertz". Change the summmary to use the names from the config file. Update the sample config file so it is more obvious what is parsed as a float, and also include "Cmdline", which was missing.
Contributor
Author
|
Here is what the updated summary looks like: Note that the quotes around the values have been dropped. |
sofar
approved these changes
Feb 9, 2025
Contributor
sofar
left a comment
There was a problem hiding this comment.
No comments from my side. These are all reasonable changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the comments summarizing the configuration/options could be confusing. E.g., "f" was used for "Filtering", but "-f" is the command-line option used to specify the sample frequency. Also, "hz" was used but there is no command-line option or config directive that mentions "hertz".
Change the summmary to use the names from the config file. Update the sample config file so it is more obvious what is parsed as a float, and also include "Cmdline", which was missing.