refactor(test): document and apply conventions#908
Merged
Conversation
c60bbe8 to
c5cb1a2
Compare
style always use long argument names unify redact fn wait_until instead of plain sleep add a skip mechanism, report separately add a mechanism to skip network tests add --stress mode add --release flag record provenance for regression tests complete redact helper simplify runner, readme
c5cb1a2 to
2f93a70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solidifies testing conventions, applies them to the existing tests, and adds some new functionality to the runner:
packages/cli/tests/README.mddocumenting these conventions.redacthelper, no morePROCESS/<process>confusion.wait_untilhelper to replace plainsleepwhere appropriate.skip_testhelper which reports in a separate category in the summary, instead of early-returning.skip_if_offlineand--offlinehelper to filter tests which require network.--releaseto test against a release build of tangram.--stress/--stress-countto run tests repeatedly, concurrently with itself, to catch races.is_failed/round_entrieshelpers.No new tests are implemented in this rollup.