Skip to content

refactor(test): document and apply conventions#908

Merged
deciduously merged 3 commits into
mainfrom
refactor/tests
Jun 10, 2026
Merged

refactor(test): document and apply conventions#908
deciduously merged 3 commits into
mainfrom
refactor/tests

Conversation

@deciduously

Copy link
Copy Markdown
Member

This PR solidifies testing conventions, applies them to the existing tests, and adds some new functionality to the runner:

  • Split multi-behavior tests into individual files per behavior.
  • Use consistent style for intent comments, using plain declarative sentences.
  • Add intent comments to all nushell and rust unit tests
  • Use long argument names.
  • Add packages/cli/tests/README.md documenting these conventions.
  • Consolidate snapshot normalization into new redact helper, no more PROCESS/<process> confusion.
  • Add wait_until helper to replace plain sleep where appropriate.
  • Add skip_test helper which reports in a separate category in the summary, instead of early-returning.
  • Add skip_if_offline and --offline helper to filter tests which require network.
  • Add --release to test against a release build of tangram.
  • Add --stress/--stress-count to run tests repeatedly, concurrently with itself, to catch races.
  • Add provenance comments citing relevant commits to tests which record a regression/bugfix.
  • Refactor runner: use options record instead of positional args, deduplicate pool refill, extract is_failed/round_entries helpers.

No new tests are implemented in this rollup.

@deciduously deciduously force-pushed the refactor/tests branch 5 times, most recently from c60bbe8 to c5cb1a2 Compare June 10, 2026 19:32
style
always use long argument names
unify redact fn
wait_until instead of plain sleep
add a skip mechanism, report separately
add a mechanism to skip network tests
add --stress mode
add --release flag
record provenance for regression tests
complete redact helper
simplify runner, readme
@deciduously deciduously merged commit c891581 into main Jun 10, 2026
@deciduously deciduously deleted the refactor/tests branch June 10, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant