WIP - Security Fix: Reduce permissions in tekton-scheduler-role #3360
Open
pramodbindal wants to merge 1 commit intotektoncd:mainfrom
Open
WIP - Security Fix: Reduce permissions in tekton-scheduler-role #3360pramodbindal wants to merge 1 commit intotektoncd:mainfrom
pramodbindal wants to merge 1 commit intotektoncd:mainfrom
Conversation
tekton-robot
added
the
release-note-none
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
the
size/M
…o tekton-operator service account only
pramodbindal
force-pushed
the
tkn-scheduler-role
branch
from
0ce9ce0 to
03ddf76
Compare
Contributor
|
@pramodbindal - is this PR still valid? the role binding change |
pramodbindal
changed the title
tekton-robot
added
the
do-not-merge/work-in-progress
Member
Author
Yes we need to refine the permissions as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Reduced the permissions of tekton-scheduler-role
Also updated the subject to tekton-operator only. Earlier this role was assigned to every authenticated user. Now only tekton-operator can have this role.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes