Skip to content

Add agentic workflows context files#3387

Open
jkhelil wants to merge 2 commits intotektoncd:mainfrom
jkhelil:SRVKP-11820
Open

Add agentic workflows context files#3387
jkhelil wants to merge 2 commits intotektoncd:mainfrom
jkhelil:SRVKP-11820

Conversation

@jkhelil
Copy link
Copy Markdown
Member

@jkhelil jkhelil commented May 4, 2026

Changes

Prepare the Tekton Operator repository for agentic workflows as part of SRVKP-11820.

  • Fix: align lint with CI and drop unused constants
  • Makefile: add a version check so the local golangci-lint binary is reinstalled when it diverges from the version pinned in ci.yaml (v2.7.2); add a PKG variable to lint-go so agents can lint a single package quickly (make lint-go PKG=./pkg/reconciler/kubernetes/tektonchain/...)
  • Remove unused resourceKind constants in tektonchain, tektonpipeline, and tektontrigger reconcilers that caused lint failures locally (pre-existing issues invisible to CI due to --new-from-merge-base)
  • Docs: add AGENTS.md and project skills
  • AGENTS.md: minimal agent-oriented context file covering single-command build/test, key conventions (InstallerSet types with cluster-observed naming, platform split, Knative runtime), architecture, and skill triggers. Confirmed acceptable in the upstream working group (29 April 2026)
  • .claude/skills/: commit-message and release-notes skills adapted from pipelines-as-code (PAC-specific references updated for this project)
  • .gitlint + make gitlint target for post-commit message validation

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

Fix two issues found during agentic workflow setup:

- Makefile: add version check so local golangci-lint binary is
  reinstalled when it diverges from the version in ci.yaml
  (v2.7.2); add PKG variable to lint-go for fast single-package
  iteration
- Remove unused resourceKind constants in tektonchain,
  tektonpipeline, and tektontrigger reconcilers that caused
  lint failures locally

Signed-off-by: Jawed khelil <jkhelil@redhat.com>
Assisted-by: Claude Sonnet 4.6 (via Cursor)
Co-authored-by: Cursor <cursoragent@cursor.com>
@tekton-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from jkhelil after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label May 4, 2026
@tekton-robot tekton-robot requested review from khrm and mbpavan May 4, 2026 11:24
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 4, 2026
@jkhelil
Copy link
Copy Markdown
Member Author

jkhelil commented May 4, 2026

/kind/cleanup

Adds tooling and documentation to support agentic workflows:

- AGENTS.md: minimal context file following agent-readiness
  principles (single-command tests, fast single-package lint,
  conventions, architecture, InstallerSet details, skills)
- .claude/skills/: commit-message and release-notes skills
  adapted from pipelines-as-code; PAC-specific references
  updated for the Tekton Operator project
- .agents/skills/: same skills in Cursor agent format
- .gitlint: commit message linting config with dependabot
  exclusion

Signed-off-by: Jawed khelil <jkhelil@redhat.com>
Assisted-by: Claude Sonnet 4.6 (via Cursor)
Co-authored-by: Cursor <cursoragent@cursor.com>
Copy link
Copy Markdown
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few questions, otherwise looks good. The 'AGENTS.md` is a bit bigger than 60 lines but I feel it is needed 👼🏼

Comment thread AGENTS.md
`knative.dev/pkg/apis` (`condSet.Manage(status).MarkTrue/MarkFalse`). Do not use
`controller-runtime` — it is not in this project.

**API layout** — all CRD types live in `pkg/apis/operator/v1alpha1/`. Each component
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to specify the version here ? (aka pkg/apis/operator/ should be good enough, isn't it ?)

Comment thread AGENTS.md

---

## PR Conventions
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have an entry stating that pull request have to follow the pull request template.


For complete detection logic, see `references/footer-detection.md`.

### Assisted-by
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Naive question, Assisted-by or Co-authored ?

@@ -0,0 +1,554 @@
# Author Detection and Footer Generation

Complete guide for detecting author information and generating required commit footers.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: these are called trailer(s) in the git realm (there is even git-interpret-trailers command to interact with it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants